Skip to content

P0: surface measured discovery wire budget in native Workbench diagnostics #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masarray merged 1 commit into from
Oct 16, 2026
Merged

P0: surface measured discovery wire budget in native Workbench diagnostics #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/ied_simulator/src/MmsClientController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ bool MmsClientController::connectToIed() {
worker->session = std::move(session);

if (self) {
QMetaObject::invokeMethod(self, [self, generation, model, associationProfile] {
const auto wireSummary = QString::fromStdString(discovery->summary());
QMetaObject::invokeMethod(self, [self, generation, model, associationProfile, wireSummary] {
if (!self || self->generation_ != generation) return;
self->treeModel_.applyDocument(*model);
self->iedName_ = QString::fromStdString(model->identity.ied_name);
Expand All @@ -475,6 +476,9 @@ bool MmsClientController::connectToIed() {
.arg(self->logicalDeviceCount_)
.arg(self->logicalNodeCount_)
.arg(self->dataAttributeCount_));
// Capture the immutable worker result once; never query
// session counters from the GUI or issue a diagnostic Read.
self->appendDiagnostic(wireSummary);
emit self->modelChanged();
emit self->stateChanged();
}, Qt::QueuedConnection);
Expand Down
5 changes: 5 additions & 0 deletions src/mms/live_discovery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ std::string MmsLiveDiscoveryResult::summary() const {
<< data_set_directories.size()
<< ", rcbReads=" << successful_controls << '/'
<< report_controls.size()
<< ", wireRequests=" << wire_budget.total()
<< " [NameList=" << wire_budget.get_name_list
<< ", GVA=" << wire_budget.get_variable_access_attributes
<< ", DataSetDirectory=" << wire_budget.get_named_variable_list_attributes
<< ", RCBRead=" << wire_budget.read_report_controls << ']'
<< ", diagnostics=" << diagnostics.size() << '.';
return stream.str();
}
Expand Down
3 changes: 3 additions & 0 deletions tests/test_live_discovery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,8 @@ void live_discovery_builds_csharp_compatible_read_only_model() {
CHECK(result.wire_budget.get_named_variable_list_attributes == 1U);
CHECK(result.wire_budget.read_report_controls == 1U);
CHECK(result.wire_budget.total() == read_only_requests);
const auto budgetSummary = result.summary();
CHECK(budgetSummary.find("wireRequests=6 [NameList=3, GVA=1, DataSetDirectory=1, RCBRead=1]") != std::string::npos);
}


Expand Down Expand Up @@ -638,6 +640,7 @@ void verified_data_set_hints_restore_late_ln_type_schema() {
CHECK(result.wire_budget.get_variable_access_attributes == 2U);
CHECK(result.wire_budget.read_report_controls == 0U);
CHECK(result.wire_budget.total() == 6U);
CHECK(result.summary().find("wireRequests=6 [NameList=3, GVA=2, DataSetDirectory=1, RCBRead=0]") != std::string::npos);
}

void disconnected_optional_probes_do_not_inflate_wire_budget() {
Expand Down
Loading