Repository navigation
fix(goose): stable publisher selection, coherent live inspector and v1.4.2 hotfix - #48
Conversation
…rministic burst tests
…rministic burst tests
…nt inspector mode
…istorical snapshot
…n raw state store
… distinct source MACs
… and remove timeline view resets
…elected publisher identity
Exact-SHA validation — v1.4.2 GOOSE selection hotfix candidatePR HEAD: All six checks completed SUCCESS for this exact SHA:
Candidate artifact: Installer SHA256 (verified directly against archive bytes): Important remaining gate — real Windows UI/traffic: while automated tests cover keyed reconciliation, real WPF mouse-click retention under sustained GOOSE retransmissions, selected-row highlighting at 100/125/150% DPI, switch to/from historical timeline, physical NIC/SCL mapping, STALE/resume and same-name multi-publisher behavior still need operator bench acceptance on the exact candidate EXE. CI cannot prove this. Keep PR draft and avoid publishing a stable release until that evidence is supplied. No v1.4.1 release/tag/assets changed, no auto-merge, and no manual rerun/duplicate CI request was triggered. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Scope / provenance
mainSHA561bf69a5cceee76d66b46350decea1e7da7593d, published v1.4.1.Code-level root cause addressed
GooseMessageItemobjects each snapshot; WPF ListView was bound to fully replacedIReadOnlyListandSelectedItemto a short-lived object. View recreation/null feedback could clear selection.Refresh()reset the DataGrid.Implementation
GoosePublisherKey: source MAC + APPID + VLAN + exact GoCBRef (fallback GoID/DataSet only if no GoCBRef); excludes stNum/sqNum/last-seen.ObservableCollection<GoosePublisherRow>with persistent row instances and change-specific property notifications.Verification matrix
Automated: Windows CI, Runtime Stability, Runtime Architecture, CodeQL, candidate Windows/Inno install + repair, repository health at exact PR HEAD SHA. Runs are required before approval; a green CI does not constitute mouse-click proof.
Manual Windows acceptance still required: sustained real GOOSE stream, single click at 100%, 125%, 150% DPI; retransmissions OFF/ON; multiple publishers; changes of filter/search; select timeline then publisher; STALE/recovery; matching/missing SCL. Verify About BuildInfo exact commit and installed executable hash against candidate manifest.
CI efficiency
One focused PR branch (no redundant branch builds), version reserved pre-PR so the Inno package gate won't fail on the already-published v1.4.1. Normal concurrency cancellation handles superseded SHA builds; rerun only failed jobs after code changes. No release tagging or auto-merge.
Do not merge/release as validated until workflows are green and field selection acceptance is recorded.