Skip to content

chore(example): replace react-native-quick-crypto with buffer - #456

Open
chrispader wants to merge 1 commit into
fix/async-row-batch-deliveryfrom
nitro-v1/example-buffer
Open

chrispader wants to merge 1 commit into
fix/async-row-batch-deliveryfrom
nitro-v1/example-buffer

Conversation

@chrispader

@chrispader chrispader commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

The example app installs react-native-quick-crypto and @craftzdog/react-native-buffer only to set a global Buffer. react-native-quick-crypto is a Nitro 0.x module, so it can't build once the library moves to Nitro V1. This replaces both with the buffer package, which needs no native code.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
react-native-nitro-sqlite Ready Ready Preview Oct 23, 2026 12:19am UTC

Request Review

@chrispader
chrispader added this pull request to stack #461 October 22, 2026 18:19
@chrispader
chrispader removed this pull request from stack #461 October 22, 2026 20:15
@chrispader
chrispader force-pushed the nitro-v1/example-buffer branch from 3a5ae3f to af078f4 Compare October 22, 2026 20:15
@chrispader
chrispader changed the base branch from chore/example-rn-upgrade to v1 October 22, 2026 20:15
@chrispader
chrispader added this pull request to stack #464 October 22, 2026 20:16
The example only used react-native-quick-crypto and
@craftzdog/react-native-buffer to provide a global Buffer. The buffer
package covers that without native code and drops a Nitro 0.x module
that can't build against Nitro V1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chrispader
chrispader removed this pull request from stack #464 October 23, 2026 00:18
@chrispader
chrispader force-pushed the nitro-v1/example-buffer branch from af078f4 to 5a8e3f1 Compare October 23, 2026 00:19
@chrispader
chrispader changed the base branch from v1 to fix/async-row-batch-delivery October 23, 2026 00:19
@chrispader
chrispader added this pull request to stack #466 October 23, 2026 00:19

This branch was successfully deployed

1 active deployment
Preview — 5a8e3f13 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant