Repository navigation
Rewrite core architecture - #89
Merged
Merged
Conversation
Replace the MeshField{V,M,B,D}/AbstractDomain hierarchy with a unified
AbstractMeshField{N,T,V} and make the narrow band a field subtype
(NarrowBandMeshField) carrying its own active node/cell indices.
- decouple interpolation into a thread-safe InterpolatedField wrapper and
move Bernstein polynomial machinery into bernstein.jl
- move signed-distance shapes into sdf.jl and reinitialization onto the new
interpolation interface
- replace the simulation log with prehook/posthook callbacks
- refactor derivatives, level-set terms, time integrators and the evolution
loop against the new field interface
- add levelsetops.jl with grid geometry operators and set operations
- simplify boundary conditions (bc_stencil mechanism, add SymmetryBC, drop
time-dependent Dirichlet)
- update Makie/MMG extensions and docs for the new API
The ImplicitIntegration quadrature extension is intentionally held back for a
follow-up PR.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
===========================================
- Coverage 89.71% 76.42% -13.30%
===========================================
Files 16 17 +1
Lines 1702 1442 -260
===========================================
- Hits 1527 1102 -425
- Misses 175 340 +165 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
PRis a full review and rewrite of the library (assisted by Claude). Its goal is to streamline the interface, improve on theNarrowBandMeshFieldsupport, and various performance tweaks (including multi-threaded support). I tried to split this into smaller PRs, but things got too tangled and complex, so I am accepting this as a major rewrite.