Repository navigation
Update clamav-unofficial-sigs to 8.0.0 - #95
Merged
ksylvan merged 1 commit intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #93
What is the current behavior (you can also link to an open issue here) ?
The image ships clamav-unofficial-sigs 7.2.5. Among the faults listed in the 8.0.0 release notes, these apply to this image's default configuration:
urlhaus.ndbstraight after installing it.email/bank_rule.yar, is gone upstream, so every update that fetches it fails to download it.8.ALERT. Upstream master is now 8.0.0, so every such check reports it.What is the new behavior (if this is a feature change) ?
The image ships 8.0.0. Its
master.conf(config version 97 → 100) disables Yara-Rules by default, removesbank_rule.yar, and moves four maldoc rules with known ClamAV problems toDISABLED. It also sets the MalwarePatrol free product code to32. The new ditekshen and twinclams sources are disabled by default.master.confbelongs to the image, and users configure throughuser.conf, which still overrides it. An existinguser.confthat setsyararulesproject_enabled="yes", as the README example did, keeps Yara-Rules on. 8.0.0 then writes a deprecationWARNINGto its own log file on each run. Warnings are not printed when there is no terminal, so the warning stays out of the container log.URLhaus is turned off, in the image's
os.conf(urlhaus_enabled="no"). 8.0.0 fixes the urlhaus bugs above, but abuse.ch now serves the URLhaus ClamAV signatures only with an Auth-Key, and 8.0.0 has no setting for one, so every download fails (see the testing notes below). The comment beside the setting says to turn it back on once upstream supports an Auth-Key.What else changed
os.conf: besides turning URLhaus off, the header comment now matches upstream'sos.debian.conf. Upstream'sos.debian.confnow setsclamd_reload_opt="clamdscan --reload". Since Clamav unofficial sigs cron #94 the image already reloads that way, once clamd has finished starting. 8.0.0 adds a socket fallback when the reload fails, but it only triggers when the reload command printsERROR, the same check as 7.2.5. So the image keeps its own reload script.user.confno longer enables the Yara-Rules project, and its commented MalwarePatrol product code is32.--install-cronwrites, apart from the random minute now being 0–59 instead of 1–59; the--install-logrotateoutput; the pid file path; when output is printed without a terminal (onlyERRORandALERTlines); and the exit status the cron job passes on, which is non-zero only when the script stops early (configuration, lock, missing tools), since it still ends withexit $?.Type of change
Status
Todo List
How has this been tested ?
The full bats suite, one suite at a time and not as root:
git submodule update --init --recursive,make build, thenmake default,make reverse TEST_DNS=9.9.9.9,make ldap,make ldap2 TEST_DNS=9.9.9.9,make sieve,make ecdsa,make traefik_acmev1,make traefik_acmev2,make traefik_v3.default— 136 testsreverse— 81 testsldap— 66 testsldap2— 30 testssieve— 2 testsecdsa— 4 teststraefik_acmev1— 11 teststraefik_acmev2— 12 teststraefik_v3— 9 tests351 tests, 0 failures, the same counts as master. No tests were added: the cron-job tests from #94 run the updater the way cron does, as its cron user and with no terminal. On 8.0.0 they still pass: clamav can read the copy of a
user.confthat only its owner can read, the job runs cleanly and exits 0, the cron user can reload clamd, the reload waits for clamd to start, the job stays quiet while another update runs, stderr and stdout go tomail.errandmail.warning, and the job fails when the update fails.A container started with the
defaultsuite's settings was also checked by hand, after the startup update and one run of the cron job, started the way cron starts it:ERRORorALERT, and clamd reloaded after it (Database correctly reloaded, 3,689,078 signatures at start, 3,834,220 after).No updates detected. Nothing from clamav-unofficial-sigs reached the container log, and there is no/var/log/mail.err.dbs-yarais empty). The three.yarafiles in/var/lib/clamavare Sanesecurity's two and Linux Malware Detect'srfxn.yara.That check ran with URLhaus still on, and showed why it is now off. On 2026-10-21
https://urlhaus.abuse.ch/downloads/urlhaus.ndbanswers410 Gone, and the URLhaus API page now says its ClamAV signature download needs an abuse.ch login and Auth-Key. 8.0.0 downloads fromurlhaus_urlwithout one and has no setting for a key. The same check on 2026-10-17 did installurlhaus.ndb(6.2 MB), which 7.2.5 never managed, so 8.0.0's urlhaus fixes work but now have nothing to fetch. Each update recorded the failure as aWARNINGin the script's own log (warnings are not printed without a terminal).os.conf, the startup update makes no URLhaus request. Its log only saysRemoving disabled urlhaus Database files, so an installedurlhaus.ndbis removed rather than left to go stale, and it has noWARNINGorERRORlines. Thedefaultsuite still passes, 136 tests.