Skip to content

Start the video player at half volume - #404

Merged
lstein merged 2 commits into
masterfrom
lstein/fix/video-default-volume
Sep 27, 2026
Merged

lstein merged 2 commits into
masterfrom
lstein/fix/video-default-volume

Conversation

@lstein

@lstein lstein commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Summary

The embedded video player started the first clip of a session at full volume. It now starts at 50%.

  • The volume is set once when the player initializes, not on every open. The player reuses one <video> element for the whole page session, so a volume the user picks carries over to the next clip.
  • The chosen volume is not saved across page reloads; each reload starts at 50% again.

Tests

  • Two new Jest tests: the player starts at half volume, and a user-chosen volume is kept for the next clip.
  • Both video-player test suites pass (75 tests); eslint and prettier are clean.
  • Tested manually in the running app.

🤖 Generated with Claude Code

lstein and others added 2 commits September 27, 2026 12:29
A <video> element starts at full volume, so the first clip of a session
played loud. Set the volume to 50% once when the player is initialized;
the element is permanent, so a volume the user picks carries over to the
next clip for the rest of the page session.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lstein
lstein enabled auto-merge (squash) September 27, 2026 16:48
@lstein
lstein merged commit 5b43fdf into master Sep 27, 2026
10 checks passed
@lstein
lstein deleted the lstein/fix/video-default-volume branch September 27, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant