Skip to content

ci: force PyPI botocore so awslocal works on GitHub runners - #275

Merged
HarshCasper merged 3 commits into
masterfrom
fix/failing-sample-ci
Sep 22, 2026
Merged

HarshCasper merged 3 commits into
masterfrom
fix/failing-sample-ci

Conversation

@HarshCasper

Copy link
Copy Markdown
Member

The GitHub-hosted runner ships a Debian de-vendored system botocore (python3-botocore, no botocore.vendored subpackage). pip treats boto3/botocore as already satisfied and never installs the PyPI build, so awslocal's unguarded 'from botocore.vendored.requests...' import in awscli's s3transfer fails with:

ModuleNotFoundError: No module named 'botocore.vendored'

This broke ~20 samples' 'make test-ci' at the awslocal step. Installing PyPI boto3/botocore into the user site shadows the system package and restores botocore.vendored.

The GitHub-hosted runner ships a Debian de-vendored system botocore
(python3-botocore, no botocore.vendored subpackage). pip treats
boto3/botocore as already satisfied and never installs the PyPI build,
so awslocal's unguarded 'from botocore.vendored.requests...' import in
awscli's s3transfer fails with:

    ModuleNotFoundError: No module named 'botocore.vendored'

This broke ~20 samples' 'make test-ci' at the awslocal step. Installing
PyPI boto3/botocore into the user site shadows the system package and
restores botocore.vendored.
remotesynth
remotesynth previously approved these changes Sep 22, 2026
Creating an AWS::ElasticLoadBalancingV2::LoadBalancer (ALB) requires at
least two subnets in two different Availability Zones. The sample defined
only one subnet, so 'make test-ci' failed at deploy with:

    CREATE_FAILED: LoadBalancer ... ValidationError: At least two subnets
    in two different Availability Zones must be specified

Widen the VPC to /16 and add a second /24 subnet in AZ index 1, wiring
both into the load balancer. Verified locally against LocalStack Pro:
stack deploys and both ALB endpoints (/hello1, /hello2) return HTTP 200.
@HarshCasper
HarshCasper merged commit a67eb63 into master Sep 22, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants