Repository navigation
Conversation
livekit/egress#1462 lets a client give each stream an id (StreamOutput.destinations, UpdateStreamRequest.add_destinations) and reports it back on StreamInfo.id, since redacted urls and the order of stream_results cannot tell streams apart. Starting with destinations already works through a StreamOutput; adding them to a running egress needed updateStream to pass them on. Updates @livekit/protocol to 1.53.1, the first release with these fields, and re-exports StreamDestination.
🦋 Changeset detectedLatest commit: 32f390a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to livekit/egress#1462 (requested in livekit/egress#1423), on livekit/protocol#1873: egress now lets a client give each stream an id of its own, through
StreamOutput.destinationsandUpdateStreamRequest.add_destinations, and reports it back onStreamInfo.id. This exposes it in the Node server SDK.EgressClient.updateStreamtakes an optional fourth argument,addDestinations, sent asadd_destinations. A stream added this way is removed like any other, withremoveOutputUrls.StreamDestinationis re-exported fromlivekit-server-sdk.@livekit/protocolgoes to 1.53.1, the first release with these fields (the same bump Update Update LiveKit dependencies (non-major) #769 carries).Starting an egress with destinations needed no change: a
StreamOutputbuilt withdestinationsalready goes throughstartRoomCompositeEgressand the other start methods, and a unit test pins it.Tests:
src/EgressClient.test.tschecks the request bodies of both calls, and theupdateStreamsmoke test intest/apinow sends a destination (passes againstlivekit/test-server:latest).