You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Change return to $result for method return values in refinements #133
return is a statement, and it's strange to have it as a variable to represent the return value.
Therefore, we could change it for result. But since result can be an actual variable that represents something other than the return value we, we can try using $result.
This would mean a small change in the grammar, probably, and a change in replacing the return value.
Ps: the _ should still work in any case
Hi 👋 I’d like to work on this issue and implement the $result replacement as suggested.
I’ll make sure _ continues to work as well.
Please let me know if there’s anything specific you’d like me to watch out for.
Hi,
I’ve implemented a fix for the refinement variable mapping issue ('_' and 'return' → $result). I’ve tested it manually, and the branch is ready.
I’ve created a Pull Request here: #145
Please take a look when you get a chance. Let me know if any further changes are needed.
Activity
alcides commentedon Dec 10, 2025
I support this change. I never liked return in the refinement for that reason.
rajshivu commentedon Feb 9, 2026
Hi 👋 I’d like to work on this issue and implement the $result replacement as suggested.
I’ll make sure _ continues to work as well.
Please let me know if there’s anything specific you’d like me to watch out for.
rajshivu commentedon Feb 9, 2026
Hi,
I’ve implemented a fix for the refinement variable mapping issue ('_' and 'return' → $result). I’ve tested it manually, and the branch is ready.
I’ve created a Pull Request here: #145
Please take a look when you get a chance. Let me know if any further changes are needed.