Repository navigation
test(sidebar): isolate bookmark UT cases from shared test data - #418
deepin-bot[bot] merged 1 commit into
Conversation
Bookmark cases wrote bookmarks into the shared tests/files/1.pdf and later cases depended on that leftover state, so the full UT run failed. 书签用例把书签写入共享的 1.pdf,后续用例又依赖这份残留状态, 导致全量执行时相互污染失败。 Log: 修复书签 UT 用例间的状态污染 Influence: 书签用例各自清理写盘数据,全量 1264 条 UT 可稳定通过。
|
Sorry @dengzhongyuan365-dev, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 2 days and 1 hour by commenting |
Reviewer's GuideThe PR removes shared-document state leakage from bookmark unit tests by stubbing required document metadata and cleaning up persisted bookmarks, while making sidebar loading validation derive expected counts from the DocSheet state. This allows the full unit-test suite to run reliably without ordering-dependent bookmark data. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Bookmark cases wrote bookmarks into the shared tests/files/1.pdf and later cases depended on that leftover state, so the full UT run failed.
书签用例把书签写入共享的 1.pdf,后续用例又依赖这份残留状态,
导致全量执行时相互污染失败。
Log: 修复书签 UT 用例间的状态污染
Influence: 书签用例各自清理写盘数据,全量 1264 条 UT 可稳定通过。
Summary by Sourcery
Isolate bookmark unit tests from shared persisted state to ensure reliable full-suite execution.
Bug Fixes:
Enhancements:
Tests: