Repository navigation
fix(notification): prevent bubble window from taking focus - #1731
Merged
deepin-bot[bot] merged 1 commit intoSep 10, 2026
Merged
Conversation
Reviewer's GuideThe PR makes notification banners non-focusable by applying Qt.WindowDoesNotAcceptFocus, adds a platform-name guard for screen-lock initialization in tests, and introduces an automated workflow to generate and optionally submit Debian changelog updates. Flow diagram for non-focusable notification bannersflowchart LR
N[Notification appears] --> B[Bubble window]
B --> F[Qt.WindowDoesNotAcceptFocus]
F --> A[Active window keeps keyboard focus]
B --> I[Hover, close, and action buttons remain interactive]
Flow diagram for automated Debian changelog updatesflowchart LR
T[Workflow dispatch or reusable workflow call] --> C[Checkout base branch]
C --> P[Prepare changelog data]
P --> G[Generate changelog]
G --> D{create_pr enabled}
D -->|yes| R[Create pull request]
D -->|no| U[Upload generated changelog artifact]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/update-changelog.yml" line_range="41" />
<code_context>
+ create_pr:
+ required: false
+ type: boolean
+ default: true
+ secrets:
+ APP_ID:
</code_context>
<issue_to_address>
**issue (bug_risk):** A reusable workflow call that omits `create_pr` defaults to `true`, but `APP_ID` and `APP_PRIVATE_KEY` are optional; without those secrets, the app-token step fails and the changelog job cannot create the pull request. The pull-request step also passes only the app-token output rather than falling back to `github.token`.
**Triggers:** When another workflow invokes `workflow_call` without supplying the optional GitHub App secrets.
**Suggested fix:** Default `create_pr` to false unless app credentials are guaranteed, or use the fallback token for the pull-request step and validate the required credentials when PR creation is requested.
```suggestion
default: false
```
</issue_to_address>1. Add Qt.WindowDoesNotAcceptFocus flag to the bubble window 2. Align with dock and OSD windows that already suppress focus stealing 3. Notification popup no longer grabs focus from the active window Log: Notification banner window no longer takes focus Influence: Active window keeps focus when a banner appears fix(notification): 通知横幅窗口不再抢占焦点 1. 为横幅窗口添加 Qt.WindowDoesNotAcceptFocus 标志 2. 与停靠栏、OSD 窗口保持一致,抑制焦点抢占 3. 通知弹出时活动窗口焦点保持不变 Log: 通知横幅弹出时不再抢占活动窗口焦点 PMS: BUG-375861 Influence: 通知横幅弹出时活动窗口保持焦点 Change-Id: Ifd3ba9abd70dae62e2db3703e7d5c70658173b3f
mhduiy
force-pushed
the
fix/notification-bubble-focus
branch
from
September 10, 2026 07:15
7da7386 to
de87e6b
Compare
18202781743
approved these changes
Sep 10, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The notification banner window steals keyboard focus from the active window when a notification pops up. Add
Qt.WindowDoesNotAcceptFocusso the banner never grabs focus, matching the dock and OSD windows which already use this flag.Qt.WindowDoesNotAcceptFocusto the bubble window flagsLog
Notification banner window no longer takes focus
Influence
Active window keeps focus when a banner appears
PMS: BUG-375861
Summary by Sourcery
Bug Fixes: