Repository navigation
daemon: Cancel ceremony if UI disappears - #243
Merged
iinuwa merged 1 commit intoOct 15, 2026
Merged
Conversation
iinuwa
requested changes
Oct 15, 2026
iinuwa
left a comment
iinuwa
left a comment
Member
There was a problem hiding this comment.
This is a good start, but there's a little more to this to make it robust. (I have a branch from a while back that contains some of the fixes I'm looking for, but needs to be broken apart and split up.)
Let's work to merge this, and then follow up with some other changes.
Can you:
- Add a changelog note
- modify the commit message to use
daemon:instead offeat:?
michaelbeaumont
changed the title
michaelbeaumont
changed the title
michaelbeaumont
force-pushed
the
fix/cancel-on-ui-exit
branch
from
October 15, 2026 18:22
3bc4174 to
829021f
Compare
michaelbeaumont
force-pushed
the
fix/cancel-on-ui-exit
branch
from
October 15, 2026 18:22
829021f to
a1c44ca
Compare
Contributor
Author
|
@iinuwa ok I think I got it :D |
iinuwa
approved these changes
Oct 15, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if the UI window is just killed, no other ceremonies can start until the service is restarted.