Skip to content

Update the PPT - #615

Merged
jeremykubica merged 3 commits into
mainfrom
version_labels
Oct 14, 2026
Merged

jeremykubica merged 3 commits into
mainfrom
version_labels

Conversation

@jeremykubica

@jeremykubica jeremykubica commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Small cleanups to the PPT:

  • Add comments with version labels to all the SHA hashes for better readability.
  • Remove an unneeded [virtualenv] specifier.
  • Remove trailing white space from some lines.

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

@jeremykubica
jeremykubica requested a balanced review from Copilot October 14, 2026 15:13
@jeremykubica
jeremykubica marked this pull request as ready for review October 14, 2026 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Requested hooks and version labels remain incomplete, and equivalent ASV workflows are inconsistent.

4 open findings
What changed in this PR

Adds readability and baseline validation improvements to generated projects and repository workflows.

Changes:

  • Adds version labels to many SHA-pinned dependencies.
  • Adds standard pre-commit file validation hooks.
  • Simplifies one ASV installation command.
File Description
python-project-template/​.pre-commit-config.yaml.jinja Adds hook labels and validations.
python-project-template/​.github/​workflows/​pre-commit-ci.yml.jinja Labels action pins.
python-project-template/​.github/​workflows/​{% if include_docs %}build-documentation.yml{% endif %}.jinja Labels action pins.
python-project-template/​.github/​workflows/​{% if include_benchmarks %}publish-benchmarks-pr.yml{% endif %}.jinja Labels publishing action pins.
python-project-template/​.github/​workflows/​{% if include_benchmarks %}asv-pr.yml{% endif %}.jinja Labels benchmark action pins.
python-project-template/​.github/​workflows/​{% if include_benchmarks %}asv-nightly.yml{% endif %}.jinja Labels nightly action pins.
python-project-template/​.github/​workflows/​{% if include_benchmarks %}asv-main.yml{% endif %}.jinja Simplifies ASV installation and labels pins.
python-project-template/​.github/​workflows/​{% if contains_code %}testing-and-coverage.yml{% endif %}.jinja Labels testing action pins.
python-project-template/​.github/​workflows/​{% if contains_code %}smoke-test.yml{% endif %}.jinja Labels smoke-test action pins.
python-project-template/​.github/​workflows/​{% if contains_code %}publish-to-pypi.yml{% endif %}.jinja Labels publishing action pins.
.github/​workflows/​testing-and-coverage.yml Labels repository CI action pins.
.github/​workflows/​smoke-test.yml Labels repository smoke-test pins.
.github/​workflows/​pre-commit-ci.yml Labels repository pre-commit pins.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread python-project-template/.pre-commit-config.yaml.jinja Outdated
Comment thread python-project-template/.pre-commit-config.yaml.jinja Outdated
Comment thread python-project-template/.github/workflows/pre-commit-ci.yml.jinja
@jeremykubica
jeremykubica merged commit 29b5715 into main Oct 14, 2026
8 checks passed
@jeremykubica
jeremykubica deleted the version_labels branch October 14, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants