Repository navigation
Send one slack alert per failure - #603
Closed
jeremykubica wants to merge 2 commits into
Closed
jeremykubica wants to merge 2 commits into
jeremykubica wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The generated workflow template remains unchanged, so downstream projects still send duplicate alerts.
1 open finding
What changed in this PR
Moves Slack failure notifications outside the Python matrix to send one alert per workflow failure.
Changes:
- Adds a dedicated notification job.
- Reports the aggregate build result.
| File | Description |
|---|---|
.github/workflows/smoke-test.yml |
Sends one Slack alert after matrix completion. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+45
to
+48
| notify: | ||
| needs: build | ||
| runs-on: ubuntu-latest | ||
| if: ${{ always() && needs.build.result == 'failure' && github.event_name != 'workflow_dispatch' }} |
Contributor
There was a problem hiding this comment.
Moved the generated workflow’s optional email and Slack notifications into one failure-gated job and updated messages to report the build result. Commit: e17805d.
Co-authored-by: jeremykubica <104161096+jeremykubica@users.noreply.github.com>
Collaborator
Author
|
I don't this fully fixes the problem yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #434
Smoke test only sends one error per failure.