Repository navigation
feat(cards): send card authorization requests to webhookEndpoint, configured through platform config - #1247
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
[Medium impact] The PR appears safe to merge; no actionable contract or documentation issues were found. SummaryMoves real-time card authorization to the platform's existing
No actionable issues were found.
|
|
🦣 Congratulations @shreyav - your substantive review earned a Siberian unicorn! (rare)
View your Frost-dex: https://zeus.dev.dev.sparkinfra.net/#/dinodex/shreyav?section=ice-age |
|
📌 Bolt Status 2026-10-28 20:43:09 UTC — ⚡ Agent |
|
⚡ Review rounds — updated in place, latest first. Round 2 · 99eca73
Earlier rounds (1)Round 1 · 05b5a3eCommits
|
Moves the endpoint from its own /platform/card-authorization-endpoint resource into cardConfigs.authorizationEndpoint on PATCH /platform/config, where every other platform setting lives. The test request now runs on the PATCH, and a failed test request rejects the whole update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ng it responseTimeoutMs is a single global value that integrators can't act on, and lowering it would be a breaking change, so the deadline is now part of the documented contract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Endpoint Replace cardConfigs.authorizationEndpoint with cardConfigs.realTimeAuthorization, which carries only timeoutBehavior. CARD_AUTHORIZATION.REQUEST now goes to the platform's webhookEndpoint. Drop the isTest request and the test delivery that gated saving the endpoint. Co-Authored-By: AaryamanBhute <AaryamanBhute@users.noreply.github.com> Co-Authored-By: shreyav <shreyav@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6f255bb to
05b5a3e
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
⚡ Review ledger Round 1
Round 2
|
Move the CardRealTimeAuthorization Stainless model under platform config, keep one description of the setting, and call the request a decision request in the PATCH description. Co-Authored-By: shreyav <shreyav@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Follow-up to #1212, addressing Shreya's review: card authorization needs neither its own resource nor its own URL.
Changes
GET/PUT/DELETE /platform/card-authorization-endpointandCardAuthorizationEndpointRequest.CARD_AUTHORIZATION.REQUESTnow goes to the platform's existingwebhookEndpoint.cardConfigs.realTimeAuthorization(nullableCardRealTimeAuthorizationwith one field,timeoutBehavior), set throughPATCH /platform/config. Omitting it keeps the setting,nullturns real-time authorization off, and an object turns it on or updates it.isTestfromCardAuthorizationRequest, along with the test delivery that gated saving the endpoint and its400 WEBHOOK_DELIVERY_ERROR.Nothing calls the removed resource yet. The webdev implementation (lightsparkdev/webdev#38554–#38557) has not merged and is being reworked to match.
🤖 Generated with Claude Code