Repository navigation
docs: add rule-based accounts guide and document USDC support - #1242
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Author
|
@greptile review |
Contributor
 [Low impact] The changes reach API and product documentation only. The PR appears safe to merge, with a non-blocking correction to the sweep failure list. Findings
Fix with agent prompt### Issue 1
mintlify/payouts-and-b2b/depositing-funds/rule-based-accounts.mdx:143-146
This list leaves out `QUOTE_EXECUTION_FAILED`. A sweep that was priced but fails before settlement reports this reason, as documented by `IncomingTransactionFailureReason`. Add it and distinguish it from failures before pricing, so developers do not build alerts or reconciliation checks that miss these failed sweeps.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryAdds a rule-based accounts guide and documents USDC account creation.
Reviews (1) · Last reviewed commit: "docs: add rule-based accounts guide and ..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+143
to
+146
| A sweep that can't be completed fails with one of these reasons, and the funds move to the account holder's own internal account in the same currency: | ||
|
|
||
| - `SWEEP_AMOUNT_OUT_OF_RANGE`: The amount is below `minimumAmount` or above `maximumAmount`. | ||
| - `SWEEP_QUOTE_FAILED`: Grid couldn't price the sweep. |
Contributor
There was a problem hiding this comment.
This list leaves out QUOTE_EXECUTION_FAILED. A sweep that was priced but fails before settlement reports this reason, as documented by IncomingTransactionFailureReason. Add it and distinguish it from failures before pricing, so developers do not build alerts or reconciliation checks that miss these failed sweeps.
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/payouts-and-b2b/depositing-funds/rule-based-accounts.mdx
Line: 143-146
Comment:
**Sweep failure list is incomplete**
This list leaves out `QUOTE_EXECUTION_FAILED`. A sweep that was priced but fails before settlement reports this reason, as documented by `IncomingTransactionFailureReason`. Add it and distinguish it from failures before pricing, so developers do not build alerts or reconciliation checks that miss these failed sweeps.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
Author
There was a problem hiding this comment.
Good catch, added QUOTE_EXECUTION_FAILED for sweeps that were priced and then failed before settlement ⚡
ls-bolt
Bot
force-pushed
the
10-27-rule-based-accounts-guide
branch
from
October 27, 2026 21:34
689559b to
c59a4da
Compare
Contributor
Author
|
⚡ Review rounds — updated in place, latest first. Round 2 · 548fd24
Earlier rounds (1)Round 1 · c59a4da
|
Contributor
Author
|
⚡ Review ledger Round 1
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ls-bolt
Bot
force-pushed
the
10-27-rule-based-accounts-guide
branch
from
October 27, 2026 21:53
c59a4da to
548fd24
Compare
bsiaotickchong
added a commit
that referenced
this pull request
Oct 30, 2026
#1243) ## Summary - Adds a concise **Rule-Based Accounts** guide at `payouts-and-b2b/depositing-funds/rule-based-accounts`, next to Internal Accounts in the "Managing accounts" nav group. It covers supported currencies, prerequisites, creating an account (USD and USDC tabs), sweep rule fields, tracking sweeps and `SWEEP_*` failures, and sandbox testing. - Documents **USDC** and **USDT** as supported currencies for `POST /internal-accounts`. The `currency` field and the endpoint description previously said rule-based accounts were `USD` only. Adds a `usdcDepositAddress` request example. - Links the new guide from the Internal Accounts page's next steps. ## Notes - A USDC rule-based account returns one deposit address per network the platform supports in `fundingPaymentInstructions`, not a bank account number. USDC and USDT rule-based accounts are enabled per platform, separately from USD. ## Test plan - `make build` and `make lint` pass. - Rendered the new page locally with `mint dev` (4.2.284):  Requested by @bsiaotickchong Original PR: #1242
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payouts-and-b2b/depositing-funds/rule-based-accounts, next to Internal Accounts in the "Managing accounts" nav group. It covers supported currencies, prerequisites, creating an account (USD and USDC tabs), sweep rule fields, tracking sweeps andSWEEP_*failures, and sandbox testing.POST /internal-accounts. Thecurrencyfield and the endpoint description previously said rule-based accounts wereUSDonly. Adds ausdcDepositAddressrequest example.Notes
fundingPaymentInstructions, not a bank account number. USDC rule-based accounts are enabled per platform, separately from USD.Test plan
make buildandmake lintpass.mint dev(4.2.284):Requested by @bsiaotickchong