Repository navigation
feat(transactions): add returnCode and returnCategory to ACH railDetails - #1190
Closed
ls-bolt[bot] wants to merge 3 commits into
Closed
ls-bolt[bot] wants to merge 3 commits into
ls-bolt[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: akanter <akanter@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Author
|
@greptile review |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryAdds optional
Reviews (1) · Last reviewed commit: "feat(transactions): add returnCode to AC..." · Reviewed by Greptile |
Co-Authored-By: akanter <akanter@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: akanter <akanter@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds two fields to
AchRailDetailsso platforms can tell why an ACH entry came back:returnCode: the NACHA return reason code the receiving bank returned the entry under, such asR01orR10.returnCategory: the Nacha return-rate category that code counts toward,ADMINISTRATIVEorUNAUTHORIZED.railDetailsalready reports that an entry was returned (status: RETURNED,returnedAt), but not why. Platforms need the code to track their return rate per reason. Nacha sets separate return-rate thresholds for unauthorized returns and administrative returns, so a platform also needs to know which threshold a return counts toward.Changes
AchRailDetails.returnCode: an optional string matching^R[0-9]{2}$, present withreturnedAt. It is a pattern-checked string rather than an enum, because NACHA adds codes and clients shouldn't fail to parse a new one.AchRailDetails.returnCategory: an optional newAchReturnCategoryenum.ADMINISTRATIVEcoversR02,R03andR04.UNAUTHORIZEDcoversR05,R07,R10,R11,R29andR51.R01(insufficient funds), which still carryreturnCode.returnCode.openapi.yamlandmintlify/openapi.yaml.Both fields are additive and optional, so there is no version bump.
Test plan
make buildmake lint: 0 errors; warning and info counts unchangedRequested by @akanter