Repository navigation
feat(agents): agent action webhooks for every decision; approval routes answer 403 when disabled - #1185
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
f92185b to
5e69104
Compare
| type: string | ||
| enum: | ||
| - AGENT_ACTION.PENDING_APPROVAL | ||
| - AGENT_ACTION.APPROVED |
There was a problem hiding this comment.
AUTO actions are created already APPROVED, so this never fires for them. could AUTO fire APPROVED on create too? then clients can handle every action the same way without a special case for AUTO, and a later FAILED won't be for an action they never heard about
|
webhooks/agent-action.yaml still calls itself the "pending approval" webhook and says it fires when an action needs approval. probably wants updating now that it carries all four events |
|
🦣 Congratulations @k15z - your substantive review earned a Giant short-faced kangaroo! (rare)
View your Frost-dex: https://zeus.dev.dev.sparkinfra.net/#/dinodex/k15z?section=ice-age |
5e69104 to
0db4265
Compare
0db4265 to
d4e0c58
Compare
86a624e to
3426e3b
Compare
 [Medium impact] The changes affect the documented contract for the agent approval workflow. The PR appears safe to merge, with a non-blocking update needed to the webhook instructions. Findings
Fix with agent prompt### Issue 1
openapi/components/schemas/webhooks/AgentActionWebhookEventType.yaml:4-6
The new events include final outcomes, but `openapi/webhooks/agent-action.yaml` still describes only pending approvals. It tells developers to show an approval screen and call approve or reject. Those instructions do not apply to `AGENT_ACTION.APPROVED`, `AGENT_ACTION.REJECTED`, or `AGENT_ACTION.FAILED`.
Update the webhook description to distinguish pending requests from final outcomes and explain how callers should handle each.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryExtends agent action webhook types and documents disabled-feature responses.
Reviews (1) · Last reviewed commit: "feat(agents): agent action webhooks for ..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| - AGENT_ACTION.APPROVED | ||
| - AGENT_ACTION.REJECTED | ||
| - AGENT_ACTION.FAILED |
There was a problem hiding this comment.
The new events include final outcomes, but openapi/webhooks/agent-action.yaml still describes only pending approvals. It tells developers to show an approval screen and call approve or reject. Those instructions do not apply to AGENT_ACTION.APPROVED, AGENT_ACTION.REJECTED, or AGENT_ACTION.FAILED.
Update the webhook description to distinguish pending requests from final outcomes and explain how callers should handle each.
Knowledge Base Used: Webhooks and event delivery
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/webhooks/AgentActionWebhookEventType.yaml
Line: 4-6
Comment:
**Finished actions still prompt approval**
The new events include final outcomes, but `openapi/webhooks/agent-action.yaml` still describes only pending approvals. It tells developers to show an approval screen and call approve or reject. Those instructions do not apply to `AGENT_ACTION.APPROVED`, `AGENT_ACTION.REJECTED`, or `AGENT_ACTION.FAILED`.
Update the webhook description to distinguish pending requests from final outcomes and explain how callers should handle each.
**Knowledge Base Used:** [Webhooks and event delivery](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/webhooks-api.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
…es answer 403 when disabled AgentActionWebhook's type becomes AgentActionWebhookEventType, which adds AGENT_ACTION.APPROVED, AGENT_ACTION.REJECTED and AGENT_ACTION.FAILED beside PENDING_APPROVAL, and WebhookType lists the three new events. GET /agents/approvals and the approve and reject operations answer 403 when the Agents API is not enabled for the platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TeBuC5ym3AR1ZJ6eocSFGT
3426e3b to
813653c
Compare
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Agent quote operations and `AgentAction.quote` return plain `Quote` again, and `AgentQuote` is removed. #1183 dropped `AgentQuote` because it added nothing to `Quote`, but #1184 and #1185 merged from branches made before that change and brought it back. This only reverts those three references and deletes the schema; there is no other change. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
2 participants
Agent action webhooks for every decision.
AgentActionWebhook.typebecomesAgentActionWebhookEventType, which addsAGENT_ACTION.APPROVED,AGENT_ACTION.REJECTEDandAGENT_ACTION.FAILEDbesidePENDING_APPROVAL;WebhookTypelists the three new events.GET /agents/approvalsand the approve and reject operations document a 403 when the Agents API is not enabled.