Repository navigation
docs: limit embedded-wallet OTP length and validity window - #1177
Merged
Merged
Conversation
otpLength now accepts 6-9 and expirationSeconds accepts 1-600. Values outside these ranges could be saved but failed every OTP send for the platform. Rejecting them at the config update gives a clear field error instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
github-actions
Bot
added
the
breaking-change
Contributor
|
carsonp6
marked this pull request as ready for review
October 16, 2026 17:46
Contributor
 [Low impact] The PR appears safe to merge; no actionable issues were found. SummaryNarrows
Reviews (1) · Last reviewed commit: "docs: limit embedded-wallet OTP length a..." · Reviewed by Greptile |
Contributor
Author
|
Confirmed no platforms today hold values outside of this range. |
shreyav
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrows two
EmbeddedWalletConfigfields to the values an OTP send can actually use:otpLength: 4–12 becomes 6–9.expirationSeconds: 1–86400 becomes 1–600.A config outside these ranges could be saved, and then every OTP send for that platform failed. With the narrower ranges,
PATCH /configrejects the value up front with a field error.The ranges match the OTP provider's documented limits: a 6–9 character code, and a validity window of at most 600 seconds.
Changes
openapi/components/schemas/config/EmbeddedWalletConfig.yaml: the new min/max values.openapi.yamlandmintlify/openapi.yaml: rebundled withmake build.make lint-openapiand spectral both pass.Follow-up
The vendored client is regenerated in webdev on
grid-otp-config-limits-regen. That PR lands after this one merges.🤖 Generated with Claude Code