Skip to content

refactor(customers): reuse the expected activity enums on the business info types - #1152

Merged
shreyav merged 1 commit into
mainfrom
named-enums-customers
Oct 9, 2026
Merged

shreyav merged 1 commit into
mainfrom
named-enums-customers

Conversation

@shreyav

@shreyav shreyav commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Independent PR on main.

What changed

  • The expectedMonthlyTransactionCount and expectedMonthlyTransactionVolume fields on BusinessInfo, BusinessInfoResponse, BusinessInfoUpdate, and ExpectedActivityVolumes now reference ExpectedMonthlyTransactionCount and ExpectedMonthlyTransactionVolume. Those schemas already existed; the four types repeated their values inline.
  • Rebuilt openapi.yaml and mintlify/openapi.yaml with make build.

SDK impact

The wire format is unchanged. In statically typed SDKs the two business info fields change from string to enum, which can require source changes for a consumer that creates business customers.

Test plan

  • make lint-openapi: Redocly reports the description valid, Spectral exits 0.
  • oasdiff breaking against main: no breaking changes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MYijrrgsrFLJZ5fkmC5XwJ

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Preview Oct 9, 2026 8:21pm UTC
grid-flow-builder Ignored Ignored Preview Oct 9, 2026 8:21pm UTC
grid-wallet-demo Ignored Ignored Preview Oct 9, 2026 8:21pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Critical impact] The refactor appears safe to merge with the SDK rollout coordination described by shreyav.

Summary

Reuses ExpectedMonthlyTransactionCount and ExpectedMonthlyTransactionVolume across four business schemas and updates both published bundles.

  • Accepted strings, descriptions, examples, and required fields stay unchanged.
  • No new actionable issues found.
  • shreyav acknowledged that generated SDK types can require consumer source changes and plans to coordinate that rollout.

Reviews (2) · Last reviewed commit: "refactor(customers): reuse the expected ..." · Reviewed by Greptile

@shreyav
shreyav force-pushed the named-enums-account-info branch from 3fb5777 to ca389b2 Compare October 9, 2026 17:20
@shreyav
shreyav force-pushed the named-enums-customers branch from c9e175d to fa1f658 Compare October 9, 2026 17:20
@shreyav shreyav changed the title refactor(customers): name the customer, document, invitation, and SCA enums refactor(customers): reuse the expected activity enums on the business info types Oct 9, 2026
@shreyav
shreyav marked this pull request as draft October 9, 2026 17:20
@shreyav
shreyav marked this pull request as ready for review October 9, 2026 18:21
AaryamanBhute
AaryamanBhute previously approved these changes Oct 9, 2026
…s info types

The expectedMonthlyTransactionCount and expectedMonthlyTransactionVolume
fields on BusinessInfo, BusinessInfoResponse, BusinessInfoUpdate, and
ExpectedActivityVolumes repeated their values inline. They now reference the
ExpectedMonthlyTransactionCount and ExpectedMonthlyTransactionVolume schemas
that already existed. The wire format is unchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MYijrrgsrFLJZ5fkmC5XwJ
@shreyav
shreyav changed the base branch from named-enums-account-info to main October 9, 2026 20:20
@shreyav
shreyav dismissed AaryamanBhute’s stale review October 9, 2026 20:20

The base branch was changed.

@mintlify

mintlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Oct 9, 2026, 8:22 PM

@shreyav
shreyav merged commit 86cf064 into main Oct 9, 2026
8 checks passed
@shreyav
shreyav deleted the named-enums-customers branch October 9, 2026 20:25

This branch was successfully deployed

1 active deployment
staging - mintlify — e9f6ef8c Deployed Oct 9, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants