Skip to content

fix(samples): add required currency field to UMA address destinations - #1135

Open
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20261007
Open

claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20261007

Conversation

@claude

@claude claude Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes Kotlin sample app to include the required currency field when building UMA address destinations for quotes

This change is required because UmaAddressDestination.currency was changed from optional to required in commit 6883dfd.

Context

Recent OpenAPI schema changes (last 24 hours) included:

  • railDetails added to transaction source/destination (commit 651d392)
  • expiresAt added to ApiToken (commit 817fd89)
  • BusinessInfo taxId and incorporatedOn made optional (commit b913836)
  • UmaAddressDestination.currency made required (commit 6883dfd)

Documentation review found:

  • Mintlify docs already properly document railDetails in transaction-lifecycle.mdx, receipts.mdx, and reconciliation.mdx
  • Changelog already documents all four changes
  • Grid Visualizer doesn't support UMA destinations (not affected)

Only the Kotlin sample needed updating.

Test plan

  • Verified make build passes
  • Verified make lint passes (0 errors)
  • Manual review: UMA quote destination now requires currency in request body

🤖 Generated with Claude Code

UmaAddressDestination.currency is now required per the OpenAPI schema.
Update the Kotlin sample's quote destination builder to include this field.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
claude Bot requested review from pengying and shreyav October 7, 2026 08:24
@vercel

vercel Bot commented Oct 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Oct 7, 2026 8:24am UTC
grid-flow-builder Ignored Ignored Oct 7, 2026 8:24am UTC
grid-wallet-demo Ignored Ignored Oct 7, 2026 8:24am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Sample code adds a required field to a data structure.

This fix appears safe to merge.

What we checked:

  • Account destinations stay unchanged: No. Only destinations with umaAddress reach the new line. Account destinations still use their separate builder.

Summary

The Kotlin sample now passes destination.currency when building an UMA quote destination.

  • Matches the API’s required destination field.
  • Leaves account destinations unchanged.
  • No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(samples): add required currency fiel..." · Reviewed by Greptile

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants