Repository navigation
Add ruleBasedAccountId and report a sweep's depositor as its source - #1066
Closed
ls-bolt[bot] wants to merge 1 commit into
Closed
ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
…eep's source A deposit into a RULE_BASED account is reported through the transaction that sweeps it. That transaction now names the depositor as its REALTIME_FUNDING source and the rule-based account as ruleBasedAccountId. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
bsiaotickchong
added a commit
that referenced
this pull request
Sep 23, 2026
…1069) ## Summary - Adds optional `ruleBasedAccountId` to `Transaction`, so it appears on both `IncomingTransaction` and `OutgoingTransaction`. It's set only on the transaction that sweeps a deposit out of a `RULE_BASED` account. - On those sweep transactions, `source` is now the party that made the deposit (`REALTIME_FUNDING` with the originator fields). It used to be an `ACCOUNT` source pointing at the rule-based account, which is now reported in `ruleBasedAccountId` instead. When no depositor is known, `source` falls back to that `ACCOUNT` source. - Documents that the sandbox fund endpoint reports a placeholder ACH depositor on a rule-based sweep. ## Example `INCOMING_PAYMENT.COMPLETED` for a sweep ```json { "source": { "sourceType": "REALTIME_FUNDING", "currency": "USD", "accountHolderName": "NORTHWIND TRADING LLC", "accountIdentifier": "****6789", "bankName": "Chase Bank", "bankIdentifier": "021000021", "paymentRail": "ACH", "remittanceInformation": "INV 4417", "traceNumber": "021000020123456" }, "ruleBasedAccountId": "InternalAccount:019542f5-b3e7-1d02-0000-000000000011", "destination": { "destinationType": "ACCOUNT", "accountId": "InternalAccount:019542f5-b3e7-1d02-0000-000000000005" } } ``` A given rail fills only one of `endToEndId` and `traceNumber`. RTP and FedNow use `endToEndId`; ACH and wire use `traceNumber`. ## Test plan - `make build` and `make lint-openapi` are clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Requested by @bsiaotickchong <!-- presentation:start --> 📊 [PR Presentation](https://agent-artifacts.dev.dev.sparkinfra.net/presentations/grid-api/1066/) · commit `091ce29e68c095d3aaf474fbbd859ff078fd1ba1` · 2026-09-23 <!-- presentation:end --> Original PR: #1066 --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: bsiaotickchong <bsiaotickchong@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruleBasedAccountIdtoTransaction, so it appears on bothIncomingTransactionandOutgoingTransaction. It's set only on the transaction that sweeps a deposit out of aRULE_BASEDaccount.sourceis now the party that made the deposit (REALTIME_FUNDINGwith the originator fields). It used to be anACCOUNTsource pointing at the rule-based account, which is now reported inruleBasedAccountIdinstead.Example
INCOMING_PAYMENT.COMPLETEDfor a sweep{ "source": { "sourceType": "REALTIME_FUNDING", "currency": "USD", "accountHolderName": "NORTHWIND TRADING LLC", "accountIdentifier": "****6789", "bankName": "Chase Bank", "bankIdentifier": "021000021", "paymentRail": "ACH", "remittanceInformation": "INV 4417", "traceNumber": "021000020123456" }, "ruleBasedAccountId": "InternalAccount:019542f5-b3e7-1d02-0000-000000000011", "destination": { "destinationType": "ACCOUNT", "accountId": "InternalAccount:019542f5-b3e7-1d02-0000-000000000005" } }A given rail fills only one of
endToEndIdandtraceNumber. RTP and FedNow useendToEndId; ACH and wire usetraceNumber.Test plan
make buildandmake lint-openapiare clean.🤖 Generated with Claude Code
Requested by @bsiaotickchong
📊 PR Presentation · commit
091ce29e68c095d3aaf474fbbd859ff078fd1ba1· 2026-09-23