Skip to content

docs: drop stale platform-owned rule-based account caveat - #1063

Merged
bsiaotickchong merged 3 commits into
mainfrom
09-23-drop-stale-platform-owned-account-caveat
Sep 23, 2026
Merged

bsiaotickchong merged 3 commits into
mainfrom
09-23-drop-stale-platform-owned-account-caveat

Conversation

@bsiaotickchong

@bsiaotickchong bsiaotickchong commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Platform-owned rule-based accounts are now supported: omitting customerId on POST /internal-accounts creates a platform-owned account. Two descriptions still said otherwise.

  • The customerId field on InternalAccountCreateRequest ended with "Platform-owned rule-based accounts are not available yet, so omitting this is currently rejected." That sentence is removed.
  • The POST /internal-accounts operation said rule-based accounts are available "for individual customers, and must be enabled for your platform before this endpoint accepts requests". It now says they are available "for a customer or for your platform itself", and the enablement clause is removed.

Changes

  • openapi/components/schemas/customers/InternalAccountCreateRequest.yaml: sentence removed.
  • openapi/paths/internal_accounts.yaml: availability wording updated and enablement clause removed.
  • openapi.yaml and mintlify/openapi.yaml: rebundled with make build.

Test plan

  • make build: the bundled diff contains only these two description changes.
  • make lint-openapi: exits 0.

🤖 Generated with Claude Code

Requested by @bsiaotickchong

Original PR: #1062

Platform-owned rule-based accounts are supported, so omitting customerId on
POST /internal-accounts is no longer rejected.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Copy link
Copy Markdown

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ls-bolt

ls-bolt Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

⚡ Revision log — updated in place, latest first.

Revision 3

  • Removed the "must be enabled for your platform before this endpoint accepts requests" clause from the POST /internal-accounts description, per @bsiaotickchong. Rebundled with make build, and make lint-openapi passes.
Earlier revisions (2)

Revision 2

  • Updated the POST /internal-accounts description to say rule-based accounts are available "for a customer or for your platform itself" instead of "for individual customers", per Greptile. Rebundled with make build, and make lint-openapi passes.
  • preview is still failing because Stainless's SDK-preview upload returns 401 (the org migrated to stlc). This PR doesn't cause it.

Revision 1

  • No code change. The preview failure comes from the Stainless SDK-preview upload returning 401 ("This org has migrated to stlc and is now read-only on the Stainless platform"). Other open PRs fail the same way right now. It is not caused by this one-sentence description edit. Fixing it means migrating the workflow to the new Stainless setup, which is outside this PR.

@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The documentation-only change is safe to merge after the non-blocking endpoint wording inconsistency is corrected.

Findings

  1. P2 Conflicting account availability guidance ▶
Fix with agent prompt
### Issue 1
openapi/components/schemas/customers/InternalAccountCreateRequest.yaml:17
This field now says that omitting `customerId` creates a platform-owned account, but the `POST /internal-accounts` operation still says rule-based accounts are available “for individual customers.” This contradiction can make integrators overlook the newly supported platform-owned flow. Please align the operation description and rebundle the generated contracts.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR removes an obsolete caveat from the optional customerId field and regenerates both published OpenAPI bundles. The updated field correctly presents omission as the platform-owned-account flow, but the endpoint-level description still limits rule-based accounts to individual customers and should be aligned.

  • Updates the modular InternalAccountCreateRequest schema.
  • Regenerates openapi.yaml and mintlify/openapi.yaml consistently.
  • Leaves conflicting ownership availability guidance on POST /internal-accounts.

Reviews (1) · Last reviewed commit: "docs: drop stale platform-owned rule-bas..."

account in the same currency, which is where funds land when a sweep
cannot be completed. Platform-owned rule-based accounts are not available
yet, so omitting this is currently rejected.
cannot be completed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Conflicting account availability guidance

This field now says that omitting customerId creates a platform-owned account, but the POST /internal-accounts operation still says rule-based accounts are available “for individual customers.” This contradiction can make integrators overlook the newly supported platform-owned flow. Please align the operation description and rebundle the generated contracts.

Knowledge Base Used:

Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/customers/InternalAccountCreateRequest.yaml
Line: 17

Comment:
**Conflicting account availability guidance**

This field now says that omitting `customerId` creates a platform-owned account, but the `POST /internal-accounts` operation still says rule-based accounts are available “for individual customers.” This contradiction can make integrators overlook the newly supported platform-owned flow. Please align the operation description and rebundle the generated contracts.

**Knowledge Base Used:**
- [Grid API contract](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/api-contract.md)
- [Customers and accounts API](https://app.greptile.com/lightspark/-/custom-context/knowledge-base/lightsparkdev/grid-api/-/docs/customers-and-accounts-api.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in c067e69: the operation now says rule-based accounts are available "for a customer or for your platform itself", and both bundles are rebuilt. ⚡


🤖 notarized-geyser(#1) | Feedback

…-accounts

Co-Authored-By: greptile-apps <greptile-apps@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Preview Sep 23, 2026 8:59pm UTC
grid-flow-builder Ignored Ignored Preview Sep 23, 2026 8:59pm UTC
grid-wallet-demo Ignored Ignored Preview Sep 23, 2026 8:59pm UTC

Request Review

@ls-bolt

ls-bolt Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

⚡ Review ledger

Round 1

  1. Operation says rule-based accounts are for individual customers only, which contradicts the platform-owned customerId flow → FIXED: c067e69, openapi/paths/internal_accounts.yaml plus the rebuilt bundles (lint-openapi clean)

@mintlify

mintlify Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Sep 23, 2026, 9:00 PM

Co-Authored-By: bsiaotickchong <bsiaotickchong@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@bsiaotickchong
bsiaotickchong merged commit 141750d into main Sep 23, 2026
10 of 11 checks passed
@bsiaotickchong
bsiaotickchong deleted the 09-23-drop-stale-platform-owned-account-caveat branch September 23, 2026 21:21

This branch was successfully deployed

1 active deployment
staging - mintlify — 3a12b5f8 Deployed Sep 23, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants