Conversation
Make it easier to consume VSS crates as a library. I've limited direct crate dep semver versions to the first MSRV+semver compatible crate that compiles and passes all tests. * tokio-v1.30 is the first version that supports `OnceCell::const_new` without the `parking_lot` crate enabled
|
👋 Thanks for assigning @tnull as a reviewer! |
|
Looks like vss-server also needs something like lightningdevkit/ldk-node#1092 to fix MSRV CI checks |
tnull
left a comment
There was a problem hiding this comment.
Not opposed to the change, but could expand a bit on a) what headache you're referring to exactly and b) what's your use case for using the crates independently from the vss-server binary?
Changes themselves LGTM I think.
The `native-tls` crate adds a ton of build headache that I'd like to avoid if I'm not actually using it. This diff makes it possible to disable it.
0d96d8d to
c257e98
Compare
|
Sure, let me expand on this a bit: a) We try really hard to use only one TLS stack (rustls) as much as we can. This is for hardening (avoid exposing more non-memory safe code to the open internet), build convenience (it's slightly annoying to configure openssl+pkgconfig in nix builds and dev machines), dependency minimization, reduced binary bloat, and reduced CI build time. So pulling in b) We're now running an internal VSS (inside our VPC with mTLS auth). It was actually really nice just pulling in the |
Okay, makes sense (though I'm not sure where I stand on the So, happy to have this land from my side, but @tankyleo still needs to review. |
|
Pushed a separate PR to fix MSRV CI issues: #117 |
server+impls: make postgres native TLS optional
The
native-tlscrate adds a ton of build headache that I'd like toavoid if I'm not actually using it. This diff makes it possible to
disable it.
cargo: relax direct dependency version requirements
Make it easier to consume VSS crates as a library. I've limited direct
crate dep semver versions to the first MSRV+semver compatible crate that
compiles and passes all tests.
OnceCell::const_newwithout the
parking_lotcrate enabled