Enforce cargo fmt on e2e-tests in CI - #291
Merged
Merged
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tankyleo
reviewed
Sep 21, 2026
tankyleo
left a comment
tankyleo
left a comment
Contributor
There was a problem hiding this comment.
Thanks do we need an update to AGENTS.md too ?
The e2e-tests crate is excluded from the workspace, so the `cargo fmt --all --check` step in CI never checked it and the weekly rustfmt bot never formatted it. Check and format the crate explicitly in both workflows and fix the drift that had accumulated in its sources. Document the separate formatting requirement in the agent instructions. AI assistance: Maple and OpenAI Codex.
benthecarman
force-pushed
the
enforce-e2e-fmt
branch
from
September 21, 2026 19:26
6876ea5 to
5f7b8c4
Compare
tankyleo
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e-tests crate is excluded from the workspace, so the
cargo fmt --all --checkstep in CI never checked it and the weekly rustfmt bot never formatted it. Check and format the crate explicitly in both workflows and fix the drift that had accumulated in its sources.