Repository navigation
fix(native): open a card's pull request where it belongs - #939
Merged
Merged
Conversation
The badge reads the pull request where the session's shell is, and a click on it, its card menu item or the footer button looked that number up on Pulls, which lists the project's pull requests. After a cd into another repository that opened the wrong pull request, or none. A shell outside the session's checkout now opens the pull request in the browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdinto another repository it opened the wrong pull request, or none.prTargetdecides once for all three: a shell inside the session's checkout opens the number on Pulls as before; one outside it opens the pull request's URL in the browser. Another worktree of the same project also goes to the browser, since a cleaned path cannot tell it from another repository.[Unreleased]› Fixed entry.Test plan
TestTheCardsPullRequestOpensWhereItBelongs(cardmenu_test.go): in the checkout and in a folder of it the click asks Pulls for the number; in another repository, and in a sibling directory sharing the checkout's prefix, it asks the browser for the URL. Before the fix the menu item asked Pulls for fix: forward the mouse wheel as a scroll instead of arrow keys #7 in every case.native/:gofmt,go vet ./...,go test ./....