Repository navigation
Remove macOS from CI - #49
Merged
Merged
Conversation
why: macOS is supported and the library works there, but the hosted macOS cells have not been a reliable signal. They gated every pull request and master push through the report job, and a single macOS cell failing in Run the complete cell reddened runs whose Linux cells all passed: master runs 39163864246 and 39016247120, and pull request runs 39125933378 and 38231812946. Bringing it back is #47. what: - Remove the macOS entry from the compatibility cell matrix, along with the macOS dependency step and the Homebrew and jemalloc branch of the tmux build - Remove the debug_enabled and native_only dispatch inputs, the native child retirement trace, the tmate debug steps and .github/scripts/trace-process.rb, which only the macOS debug cell used - Drop macos from scripts/matrix so --require-all stops demanding macOS cells, and keep the Linux-only shape with assertions in the matrix and workflow tests - Say in the READMEs and CONTRIBUTING that macOS is supported on a best-effort basis and CI coverage for it is highly limited Closes #46
why: Pull requests stop waiting on the macOS cells, and a macOS-only regression is no longer caught before merge, so the entry says what CI no longer covers and that macOS stays supported. what: - Add an unreleased entry for removing macOS from CI - State that macOS is supported best-effort with limited CI coverage
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS stays supported and works, but its CI cells are not a reliable signal. This removes them from CI. The READMEs and CONTRIBUTING now say macOS is supported on a best-effort basis with highly limited CI coverage. #47 tracks bringing it back.
macOS (#46)
compatibility.yml, with the macOS dependency step and the Homebrew and jemalloc branch of the tmux build.debug_enabledandnative_onlydispatch inputs, the native child retirement trace, the tmate debug steps and.github/scripts/trace-process.rb, which only the macOS debug cell used.macosfromscripts/matrix, so--require-allstops demanding macOS cells.Verification
matrix_test.rbasserts the Linux-only shape. Deliberate breaks: adding a macOS platform to the workflow fails the new test (Expected /macos/i to not match "macos-15"), and addingmacostoSYSTEMSfails the matrix test. Both pass restored.actionlintpasses oncompatibility.yml, andscripts/check midpasses.Closes #46