Repository navigation
Generate complete English release notes - #1
Open
diegoabadan wants to merge 1 commit into
Open
diegoabadan wants to merge 1 commit into
diegoabadan wants to merge 1 commit into
Conversation
Centralize compatibility metadata, generated changes, installation guidance, exact version validation, and runtime-only packaging in the reusable workflow. Keep existing callers compatible, make English the canonical README, pin CI dependencies, and validate workflows with actionlint. Reviewed independently by a Sol agent.
YvesLepidus
requested changes
Sep 1, 2026
| printf -- '- Application: %s\n' "$PKP_APPLICATION" | ||
| printf -- '- Compatible versions: %s\n' "$COMPATIBLE_VERSIONS" | ||
| printf -- '- Branch: %s\n' "$RELEASE_BRANCH" | ||
| printf -- '- Plugin version: %s\n\n' "$RELEASE_VERSION" |
Member
There was a problem hiding this comment.
Informar a versão do plugin não seria redundante?
| printf '## Compatibility\n\n' | ||
| printf -- '- Application: %s\n' "$PKP_APPLICATION" | ||
| printf -- '- Compatible versions: %s\n' "$COMPATIBLE_VERSIONS" | ||
| printf -- '- Branch: %s\n' "$RELEASE_BRANCH" |
Member
There was a problem hiding this comment.
Não vejo necessidade o usuário final saber de qual branch a release foi gerada.
| printf -- '- Compatible versions: %s\n' "$COMPATIBLE_VERSIONS" | ||
| printf -- '- Branch: %s\n' "$RELEASE_BRANCH" | ||
| printf -- '- Plugin version: %s\n\n' "$RELEASE_VERSION" | ||
| printf '## Changes\n\n%s\n\n' "$generated_notes" |
Member
There was a problem hiding this comment.
Não ficou muito claro pra mim como essas mudanças seriam obtidas. Seriam os títulos dos commits?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
main<-improve/complete-english-releases/tmp/github-workflows-release-notes-20260819Behavior
version.xmlexactly, creates a runtime-only package, and publishes an English release with compatibility, generated changes, and installation sections.Existing callers that only pass
plugin_nameremain compatible. The newpkp_application,compatible_versions, andrelease_branchinputs are optional for migration safety; when omitted, the release explicitly reports that the value was not specified instead of inventing metadata.Validation
similarTitlesReportCommands and results:
actionlint: passed for both workflows.v1.2.3.4for release1.2.3.4and rejectedv1.2.3.Compatibility and security
doiInSummary,scieloSubmissionsReport,plaudit,contentAnalysis,pluginUpdateNotification,languageToggleByFlag,scieloTheme,plauditPreEndorsement,referencesForChapters,selectionOfReviewingInterests,similarTitlesReport, andrepec.plugin_name-only calls remain valid.actions/checkout,softprops/action-gh-release, and the actionlint container are pinned by immutable SHA/digest.printfformats.Not specifiedfallbacks with accurate metadata.Release
version.xml, package, or tag is required for this workflow repository change.