Skip to content

fix: include RPC devices in --list-devices - #2182

Merged
leejet merged 1 commit into
masterfrom
fix/rpc-device-listing
Oct 21, 2026
Merged

leejet merged 1 commit into
masterfrom
fix/rpc-device-listing

Conversation

@leejet

@leejet leejet commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Process --list-devices after argument parsing in both CLI and server, registering RPC endpoints before enumeration regardless of option order.
  • Add sd_add_rpc_servers() without changing the existing device-listing API, and return a nonzero exit status when RPC registration fails.
  • Restore the RPC device discovery instructions.

Related Issue / Discussion

Fix #2165.

Additional Information

N/A

Checklist

Summary by CodeRabbit

  • New Features

    • Added a --list-devices option to display available local and RPC-backed devices, with clear success or failure status.
    • Added support for registering RPC servers through the public API before device enumeration.
    • Device discovery now retries backend lookup when needed and reports unavailable RPC servers.
  • Documentation

    • Updated RPC usage guidance with device-connection checks and clarified output and error behavior.

@leejet
leejet merged commit b15c8aa into master Oct 21, 2026
10 checks passed
@leejet
leejet deleted the fix/rpc-device-listing branch October 21, 2026 15:49
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 54774e24-e9fa-4a2e-94c1-9817a499f1cd
📥 Commits

Reviewing files that changed from the base of the PR and between 2e2ba3f and e30f7b9.

📒 Files selected for processing: 7
  • docs/rpc.md
  • examples/cli/main.cpp
  • examples/common/common.cpp
  • examples/common/common.h
  • examples/server/main.cpp
  • include/stable-diffusion.h
  • src/core/ggml_extend_backend.cpp
+-----------------------------+
| My other GPU is a Blackwell |
+-----------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--list-devices doesn't show RPC devices from --rpc-servers, so RPC looks broken

1 participant