String to int conversion in ASR #2554

Activity

1. ubaidsk commented on Mar 17, 2024

   

   ubaidsk

   on Mar 17, 2024

   Collaborator

   More actions

   It looks like we already have some support for string to int conversion.

   % cat examples/expr2.py 
   def main():
       x: str = "123"
       print(int(x))
   
   main()
   % python examples/expr2.py         
   123
   % lpython_in_main examples/expr2.py
   123
2. ubaidsk commented on Mar 17, 2024

   

   ubaidsk

   on Mar 17, 2024

   Collaborator

   More actions

   I think we just need to polish the existing support.
3. kmr-srbh commented on Mar 25, 2024

   

   kmr-srbh

   on Mar 25, 2024

   Last edited by kmr-srbh

   Contributor

   More actions

   @Shaikh-Ubaid I think we should support the conversion mechanism which intrinsic_int uses, for all the integer types we have. My main concern is that doing i32(int("12345")) is counterintuitive.
4. kmr-srbh commented on Mar 25, 2024

   

   kmr-srbh

   on Mar 25, 2024

   Contributor

   More actions

   The conversion mechanism for int needs to be improved too. It currently relies on std::stoi() and fails for anything larger than that. We only have to improve the BigInt library we already have.