Repository navigation
chore: Stop the data source in fdv1 specs that start a real processor - #455
Merged
Merged
Conversation
kinyoklion
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several fdv1 specs start a real stream or polling processor and never stop it. The leaked SSE thread later hits a 401 and calls an expired RSpec double, which shows up as a thread warning in CI. Add an after hook that stops the data source in the two describe blocks that start real processors.
Note
Overview
Fixes flaky CI thread warnings by teardown in
fdv1_spec.rb: anafter { subject.stop }hook was added to the#startand diagnostic accumulator integration describe blocks.Those examples call
subject.startwith realStreamProcessor/PollingProcessorinstances, which left background SSE threads running after the example finished. Those threads could later get a 401 and touch expired RSpec doubles. Stopping the data source after each example keeps processor threads from outliving the test.Reviewed by Cursor Bugbot for commit 14d5404. Bugbot is set up for automated code reviews on this repo. Configure here.