Repository navigation
feat: Add http_proxy option to route SDK requests through a web proxy - #270
Merged
Merged
Conversation
kinyoklion
reviewed
Oct 13, 2026
kinyoklion
reviewed
Oct 13, 2026
Member
This doesn't appear to be accurate. CURL reads the proxy environment variables directly and no_proxy overrides the manually specified proxy configuration. |
jsonbailey
marked this pull request as ready for review
October 13, 2026 23:14
Contributor
Author
It was fixed in the code docs but not in the PR description. I've updated it. |
kinyoklion
approved these changes
Oct 13, 2026
jsonbailey
pushed a commit
that referenced
this pull request
Oct 14, 2026
🤖 I have created a release *beep* *boop* --- ## [6.10.0](6.9.0...6.10.0) (2026-10-14) ### Features * Add http_proxy option to route SDK requests through a web proxy ([#270](#270)) ([fa5b955](fa5b955)) ### Bug Fixes * Prevent special characters in the events URI or temp file path from ([fa5b955](fa5b955)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > **Release 6.10.0** — bumps the SDK version from **6.9.0** to **6.10.0** across `LDClient::VERSION`, `.release-please-manifest.json`, and the phpDoc build title. > > Adds a **CHANGELOG** entry for 6.10.0 that records already-merged work: an **`http_proxy`** client option for proxying SDK HTTP traffic, and a fix around **special characters in the events URI or temp file paths** (no runtime code changes in this diff). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 95f8bfc. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Prevent special characters in the events URI or temp file path from breaking event delivery on Windows
Summary
Adds an
http_proxyclient option that sends all SDK requests to LaunchDarkly through a web proxy. The value is a proxy URL, for examplehttp://my-proxy:8080orhttp://user:pass@my-proxy:8080. This matches the proxy option in the Python and Go SDKs.proxyrequest option, and the curl publisher passes--proxyto curl.HTTPS_PROXYandHTTP_PROXYenvironment variables for SDK connections. TheNO_PROXYenvironment variable still applies, because curl reads it. If the option is not set, the environment variables apply as before.Invoke-WebRequest -Proxy, which does not read credentials from the proxy URL. For a proxy that requires authentication on Windows, useGuzzle::eventPublisher(). TheCurldocblock documents this.http_proxyvalue that is not a non-empty string is ignored with a warning, and the environment variables apply.Note
Overview
Adds a new
http_proxyclient configuration option so LaunchDarkly HTTP traffic can be sent through an explicit proxy URL (aligned with other LaunchDarkly SDKs).Util::httpProxy()centralizes parsing: only non-empty strings are honored; invalid values are logged and ignored so default proxy environment behavior is unchanged when the option is absent or bad.The Guzzle feature requester and event publisher pass the URL as Guzzle’s
proxyoption. The default curl event publisher adds--proxyon Unix andInvoke-WebRequest -Proxyon Windows. Docs onLDClientand the integration factories describe precedence overHTTP_PROXY/HTTPS_PROXYfor SDK calls only, plus the Windows PowerShell credential limitation.Curl event publisher also tightens PowerShell quoting for payload file paths and URIs. Tests cover curl argument wiring and integration paths that only succeed when traffic goes through a local proxy.
Reviewed by Cursor Bugbot for commit 3f6f862. Bugbot is set up for automated code reviews on this repo. Configure here.