Repository navigation
chore(deps): update launchdarkly/gh-actions/actions/contract-tests requirement to 2715574e04448246bc529a23a81766491bbc4aae - #599
Closed
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ab191af. Configure here.
| run: $TEST_SERVICE_BINARY $TEST_SERVICE_PORT 2>&1 & | ||
| # https://github.com/launchdarkly/gh-actions/releases/tag/contract-tests-v1.3.0 | ||
| - uses: launchdarkly/gh-actions/actions/contract-tests@5adb11fd6953e1bc35d9cf1fc1b4374c464e3a8b | ||
| - uses: launchdarkly/gh-actions/actions/contract-tests@2715574e04448246bc529a23a81766491bbc4aae |
There was a problem hiding this comment.
Contract-tests action silently downgraded
High Severity
This Dependabot change pins contract-tests to 2715574 (v1.1.0) from 5adb11f (v1.3.0). enable_persistence_tests only exists since v1.2.0, so on v1.1.0 that input is ignored and the harness never gets -enable-persistence-tests (default false). With extra_params limited to -run=persistent.data.store, Redis/DynamoDB persistence suites stop running while CI can still go green.
Additional Locations (1)
Triggered by learned rule: Persistence contract-test CI needs a live store, not just a harness flag
Reviewed by Cursor Bugbot for commit ab191af. Configure here.
Member
|
@dependabot rebase |
…quirement to 2715574e04448246bc529a23a81766491bbc4aae Updates the requirements on [launchdarkly/gh-actions/actions/contract-tests](https://github.com/launchdarkly/gh-actions) to permit the latest version. - [Release notes](https://github.com/launchdarkly/gh-actions/releases) - [Commits](https://github.com/launchdarkly/gh-actions/commits/2715574e04448246bc529a23a81766491bbc4aae) --- updated-dependencies: - dependency-name: launchdarkly/gh-actions/actions/contract-tests dependency-version: 2715574e04448246bc529a23a81766491bbc4aae dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/launchdarkly/gh-actions/actions/contract-tests-2715574e04448246bc529a23a81766491bbc4aae
branch
from
September 1, 2026 15:49
ab191af to
f3aef08
Compare
Contributor
|
Closing: |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/github_actions/launchdarkly/gh-actions/actions/contract-tests-2715574e04448246bc529a23a81766491bbc4aae
branch
September 8, 2026 22:47
kinyoklion
added a commit
that referenced
this pull request
Sep 9, 2026
…ion (#605) ## Summary Point every `launchdarkly/gh-actions/actions/contract-tests` usage at the floating `contract-tests-v1` tag instead of a SHA pin, and drop the now-redundant release-link comments. - Dependabot can't resolve versions for this monorepo action and proposed a *downgrade* (#599: `5adb11f`/v1.3.0 → `2715574`/v1.1.0, which silently drops the `enable_persistence_tests` input). Closed that PR; the floating tag stops the bad suggestions. - `client.yml`, `server.yml`, `sse.yml` were still on v1.1.0 and effectively move to v1.3.0. - `sse.yml` sets `enable_persistence_tests: false` — the sse-contract-tests harness has no `-enable-persistence-tests` flag and exits 2 when passed it (v1.3.0 defaults the input to true). <details> <summary>Implementation details</summary> `contract-tests-v1` is force-updated to each new release by gh-actions' release-please workflow, so it currently points at `5adb11f` (contract-tests-v1.3.0). v1.3.0 vs v1.1.0 for the workflows that were behind: - adds `enable_persistence_tests` (default `true`) → harness gets `-enable-persistence-tests`. Handled for SSE as above; for the server jobs the test service only advertises `persistent-data-store-{redis,dynamodb}` when built with `use_redis`/`use_dynamodb`, which those jobs don't do, so no additional suites run there. - adds `stop_service` (default `true`), matching v1.1.0's hardcoded `-stop-service-at-end`. Tradeoff: a floating tag is mutable, so this gives up SHA pinning for this first-party action. </details> Link to Devin session: https://app.devin.ai/sessions/01bce0d0f3894fccba4fe3fc117ff8b1 Open in Devin Desktop: https://app.devin.ai/desktop/session/01bce0d0f3894fccba4fe3fc117ff8b1?variant=devin Requested by: @kinyoklion <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Switches all contract-test CI jobs to the floating **`contract-tests-v1`** ref on `launchdarkly/gh-actions/actions/contract-tests` instead of mixed SHA pins (v1.1.0 / v1.3.0), and removes the redundant release-link comments above those steps. > > Workflows that were still on v1.1.0 (**client**, **server**, **sse**) effectively pick up v1.3.0 behavior via the tag. **sse.yml** explicitly sets **`enable_persistence_tests: false`** on both contract-test jobs so the harness is not passed `-enable-persistence-tests` (unsupported for SSE; v1.3.0 defaults that input to true). Redis/DynamoDB server jobs keep **`enable_persistence_tests: true`**; only the action ref changes there. > > **Tradeoff:** the floating tag is mutable, so SHA pinning for this first-party action is dropped in favor of simpler Dependabot/version alignment. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b674b86. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on launchdarkly/gh-actions/actions/contract-tests to permit the latest version.
Commits
Note
Overview
Pins
launchdarkly/gh-actions/actions/contract-teststo commit2715574ein the DynamoDB and Redis server SDK contract-test workflows, replacing the previous SHA5adb11fd.No workflow inputs or job structure change—only the reusable action reference. Persistence contract tests (
enable_persistence_tests, harness matrix,extra_params) run the same way against the updated action version.Reviewed by Cursor Bugbot for commit f3aef08. Bugbot is set up for automated code reviews on this repo. Configure here.