Freeze markdown without re-wrapping lines - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source add converts a document with pandoc at its default --wrap=auto, so the frozen markdown is re-wrapped at 72 columns and inline maths ends up spanning lines. Now that draft validate runs the delimiter checks, every real sheet in the PHYS40002 folder fails with "newline inside an inline $ ...$" and "opening $ $ must be followed by a newline": findings about pandoc's wrapping, not the document. The agent's replay sweep went from 15 built to 0 built on the relock because of them.
Freeze with --wrap=none so a paragraph is one line and inline maths never breaks; block line ranges still work, a paragraph simply spans one line. Then check the delimiter checks against the real export in tests/fixtures/exports: it holds 78
$$and at least one inline span with a newline in it that Lambda Feedback renders, so a check that a real export fails is a check to loosen or drop, and say which in the PR. Done when the source and spec fixtures are re-frozen without wrapping, the questions-only PHYS40002 sheets validate with no delimiter findings, and every real export still passes the checks it passed before.Workbench ticket t44.