Accept several selectors per role and report double assignment - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spec-engine limits stopped three of four PDFs in a real folder (UCL_MechEng). (1) The model wrote
ignore:as a YAML list of three selectors and the spec was refused: "A selector is a line of text, which [...] is not." A role should accept either one selector or a list of them, matched as a union; the docs and the agent's prompt then say so. (2) On a solutions-only document every block is a solution, so the layout assigns a second solution to the same target andrecordrefuses with "q1.solution is already written", and the whole spec run is rejected. A spec run must not abort on that: when the layout's target is already filled, leave the block unassigned and let it appear in the coverage report and as an overlap-style finding naming both, so the fix loop or a person can act on it. Done when a spec with a list-valued role parses and matches the union, and a solutions-only fixture runs to a coverage report instead of a refusal.Workbench ticket t48.