Report the LaTeX error, not Emergency stop - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When xelatex cannot compile the set, the compile check reports "The set: the PDF generator cannot compile this: Emergency stop." and nothing else - which is what CI showed for every draft fixture while the runner lacked four TeX packages, and nobody could tell which. "Emergency stop" is TeX's last line; the cause is the "! LaTeX Error: File `ulem.sty' not found." (or "! Undefined control sequence", or a missing font) that precedes it, and -file-line-error gives that one a file and line only when it is in the set's own text.
Read the log properly: take the first "! ..." line and the "l." line after it, and report that message; map it to a field when the line is inside the set's markers and to "The set" otherwise, keeping "Emergency stop" only as a fallback when the log holds no "!" line at all. Done when a fixture compiled with a package deliberately unavailable (an \usepackage{nosuchpackage} in a field) reports the missing file by name, and the existing latex_fault fixture still names its field.
Workbench ticket t43.