Rewrite image references to their media names on export - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A field that says
is exported unchanged while the file is copied to media/train.png, so Lambda Feedback looks for figures/train.png and shows nothing. Every real export references images by bare basename (question_000_Hydraulic_scale_0001.png, in media/), and the fixture README says so. Both routes have the bug: convert (the filters keep the url as written) and a draft's build (as_set collects references as written).
On export, rewrite every markdown image reference in every field - masterContent, part text, worked solution, answer, area texts, options - to the basename of the file that was copied into media/, and copy the file once under that name; two different files with the same basename get the export's own naming (question_NNN_<Title>_0001.png ...). Load keeps what an export says. Done when a source beside a figures/ folder converts to a set whose JSON references the media/ name and the round-trip test over every export still passes.
Workbench ticket t41.