Report a missing solution as a warning, not a refusal - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A real run over a questions-only sheet (PHYS40002 PS3: seven questions, no solutions anywhere in the file) ends with validate reporting every part as "has no solution", build refusing on it, and the agent's fix loop then inventing a worked solution as a literal to make the report clean - the one thing the design spec says a model must not do. Half the corpus is sheets whose solutions are a separate file or absent.
Split the report into errors and warnings. Coverage, overlap, gaps, empty fields and (once t37 lands) maths and compile faults are errors: build refuses on them. A part or question without a solution is a warning: it is written into the report with check "no-solution" and a level, and build proceeds and says so. Done when the questions-only fixture validates with warnings only and builds, and a draft with an uncovered block still refuses.
Workbench ticket t39.