Run the set checks in draft validate - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in2lambda validate on a draft runs only the structure checks (coverage, overlap, gaps, solutions, empty fields). The design spec's validate table also lists maths delimiters, KaTeX and the PDF compile, and those exist - Set.problems() runs them at export - but a draft that reaches build has never had them run: a real sheet with$52^{\circ}$ in it validated "nothing to report" and built.
Make draft validate also run Set.problems() over the set the draft describes (in2lambda.draft.export.as_set), with compile on when xelatex is present, and write those findings into the same report with the same shape, each naming the field key (q2.text) rather than only the export's "Question 2, main text" so an agent can act on it with field replace. build then refuses on them like any other finding. Done when the draft fixture with ^\circ in a field gets a report line naming the field and the fix, and a draft that renders clean gets none.
Workbench ticket t37.