Any software design issues #2555

Activity

1. aldas commented on Dec 5, 2023

   

   aldas

   on Dec 5, 2023

   Contributor

   More actions

   echo.context is reused for http requests and between each request we need to reset it so there would not be data leaking from one request to other. We avoid using NewContext as much as possible to avoid allocating memory.

   This happens here:
   

   echo/echo.go

   Lines 648 to 652 in 584cb85

   	func (e *Echo) ServeHTTP(w http.ResponseWriter, r *http.Request) {
   	// Acquire context
   	c := e.pool.Get().(*context)
   	c.Reset(r, w)
   	var h HandlerFunc

   and at the end of ServeHTTP that context is put back to pool to be used for another request.
2. labstack

   locked and limited conversation to collaborators on Dec 5, 2023
3. aldas

   converted this issue into a discussion #2556 on Dec 5, 2023