Skip to content

chore: remove org-enforced workflows and bump next to 16.4.2 - #48

Merged
mvantellingen merged 4 commits into
mainfrom
remove-org-enforced-workflows
Oct 25, 2026
Merged

mvantellingen merged 4 commits into
mainfrom
remove-org-enforced-workflows

Conversation

@mvantellingen

@mvantellingen mvantellingen commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Removes the repo-local pinact, zizmor and other security workflows. These checks now run as org-wide required workflows from labd/.github-workflows, so keeping copies in this repo would only run them twice.

CI fixes

npm trusted publishing

The org-level NPM_TOKEN secret is gone, so all npm publishes go through trusted publishing (OIDC). The release job already uses OIDC (environment: release, id-token: write, upgraded npm, NPM_CONFIG_PROVENANCE: true, no npm tokens). To match labd/commercetools-node-mock, this PR also:

  • adds push-with-git-cli: true to changesets/action
  • sets package.json repository.url to git+https://github.com/labd/nextjs-basic-auth-middleware.git and publishConfig.provenance to true

On npmjs.com, nextjs-basic-auth-middleware needs a trusted publisher with repository labd/nextjs-basic-auth-middleware, workflow release.yaml and environment release.

pnpm 12

Already on pnpm@12.13.0; follow-up fixes:

  • pnpm 12 ignores pnpm settings in .npmrc (pnpm config get savePrefix returned undefined), so save-prefix, auto-install-peers and strict-peer-dependencies moved to pnpm-workspace.yaml (savePrefix: "", autoInstallPeers: true, strictPeerDependencies: false) and .npmrc was removed. Verified with pnpm config get.
  • minimumReleaseAge: 10080 kept as-is (already present), trustPolicy: no-downgrade unchanged.
  • Lockfile unchanged; pnpm install --frozen-lockfile passes.
  • labd/gh-actions-typescript/pnpm-install → v1.1.0, with cache: false in the release job.

These checks now run via the org-wide required workflows in
labd/.github-workflows.
next 16.4.0 is affected by two critical advisories (GHSA-2464-fhr4-w9xw,
GHSA-673q-mjm6-r5xr), which makes the pnpm audit step in CI fail.
@mvantellingen mvantellingen changed the title Remove pinact/zizmor workflows enforced at org level Remove org-enforced workflows and bump next to 16.4.2 Oct 25, 2026
@mvantellingen mvantellingen reopened this Oct 25, 2026
@mvantellingen
mvantellingen force-pushed the remove-org-enforced-workflows branch from a274fb6 to 49677c3 Compare October 25, 2026 18:59
@mvantellingen mvantellingen changed the title Remove org-enforced workflows and bump next to 16.4.2 chore: remove org-enforced workflows and bump next to 16.4.2 Oct 25, 2026
@mvantellingen
mvantellingen merged commit 939a3e3 into main Oct 25, 2026
11 checks passed
@mvantellingen
mvantellingen deleted the remove-org-enforced-workflows branch October 25, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant