Repository navigation
build!: remove codecov, switch to ruff and require python 3.11+ - #158
Merged
Merged
Conversation
BREAKING CHANGE: requires Python 3.11 or newer.
These checks now run via the org-wide required workflows in labd/.github-workflows.
mvantellingen
force-pushed
the
ruff-and-remove-codecov
branch
from
October 25, 2026 18:58
067073b to
77c9a0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Codecov and switch linting to ruff
Codecov removal
coveragejob inpython-test.ymlthat only existed to feed Codecov. Tests still run undercoverage runvia tox, and thetox -e coverage-reportenv is kept for local use.Ruff
ruff==0.17.2) in thetestextra, thetox -e formatenv and the Makefile (format,generate, and a newlinttarget).[tool.isort]/[flake8]to[tool.ruff]inpyproject.toml(line length 88,E4/E7/E9/F/I,known-first-partykept).platform,importapi,frontend,checkout) gets a per-file ignore forF401/F541/F821, so we don't hand-edit generated files.ruff formatrun (mostly blank-line changes in generated code).tests/importapi/test_models.py, because the second definition was hiding the first. Both tests now run and pass.Note:
src/commercetools/checkout/models/common.pycontains invalid generated enum members (EUROPE_WEST1.GCP = ...), which ruff reports as F821. It is ignored here, but the generator needs fixing.Python 3.11+
Python 3.10 is EOL, so the floor moves from 3.10 to 3.11 (breaking).
setup.py:python_requires=">=3.11", dropped the 3.10 classifier (3.11–3.14 remain).tox.ini: envlist and[gh-actions]mapping cover 3.11–3.14.mypy.ini:python_version3.6 -> 3.11..readthedocs.yml: replaced the deprecated v1 config (Python 3.6) with a v2 config on Python 3.13.CHANGES.md: new Unreleased entry.Verified:
tox -e format,py311,py313all pass (175 tests).