Replace duplicate intMax helpers with builtin max

[jahnavigajjala-3]

Fixes #16664

Proposed Changes

• Replace the duplicated intMax helpers in the KPA and HPA reconcilers with Go's built-in max() function.
• Remove the now-unused intMax helper implementations from both packages.
• Rename the local max variable in kpa/scaler.go to maxScale to avoid shadowing the built-in max() function.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jahnavigajjala-3 / name: jahnavigajjala3-commits (c1256e3)

[knative-prow]

Welcome @jahnavigajjala-3! It looks like this is your first PR to knative/serving 🎉

[knative-prow]

Hi @jahnavigajjala-3. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linkvt]

/lgtm
/ok-to-test

min could be renamed to minScale to avoid also shadowing the builtin min but this is preexisting.

[codecov]

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.34%. Comparing base (333e58c) to head (a2aa379).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/reconciler/autoscaling/hpa/hpa.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16665      +/-   ##
==========================================
+ Coverage   80.30%   80.34%   +0.04%     
==========================================
  Files         217      217              
  Lines       13568    13560       -8     
==========================================
- Hits        10896    10895       -1     
+ Misses       2308     2302       -6     
+ Partials      364      363       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[linkvt]

/lgtm

[linkvt]

/retest

[dsimansk]

@jahnavigajjala-3 could you to rebase this PR pls? There's was a fix merged to GH action setup.

[jahnavigajjala-3]

@dsimansk ,Done, thanks!

[dsimansk]

/approve
/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, jahnavigajjala-3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/test istio-latest-no-mesh

[dsimansk]

/retest