Repository navigation
Fix prototype replacement when array key value is __proto__ - #322
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An array with the
keyoption builds its result aslhs = {}and assigns entries withlhs[item.key] = item. When the key value comes from parsed input and equals"__proto__", the assignment triggers the__proto__setter and replaces the hash's prototype with the parsed item instead of adding an entry. The entry vanishes fromObject.keys(), and missing properties on the hash resolve to attacker-controlled data.Repro
Fix
Use
Object.defineProperty(enumerable, writable, configurable) for the assignment, so every key,"__proto__"included, becomes an own data property.I picked this over
Object.create(null)because the result stays a plain object withObject.prototype. Existing users can still callhasOwnProperty/toStringon it, and strict deep equality (e.g.toStrictEqual, which compares prototypes) keeps working, so existing tests and user code see no change.A regression test is added in
test/composite_parser.ts.