Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: arrays with
readUntil: "eof"orlengthInBytesloop untiloffsetreaches the end. If an element consumes 0 bytes (e.g. the element is only apointer, or a seek driven by input data),offsetnever advances and the loop runs forever while the array grows until OOM.Repro (hangs):
Fix: for these two loop forms, record
offsetat the start of each iteration and throwArray element did not consume any bytesif it did not advance. Fixed-lengthandreadUntil-function arrays are unchanged. Added a regression test covering both forms.