Repository navigation
Stop tar example at the end-of-archive marker - #310
Merged
Merged
Conversation
A tar archive ends with zero-filled blocks, which the example parsed as an extra entry full of NaNs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tar archive ends with zero-filled blocks, which the example parsed as an extra entry whose fields were all
NaN. The loop only terminated becauseseek(NaN)happened to make the offset invalid.Stop reading entries when the next block starts with a zero byte. The example now outputs the same 8 entries as
tar tvf example/test.tar.