Repository navigation
Migrate Node tests from mocha/ts-node to Vitest - #302
Merged
Merged
Conversation
ts-node is unmaintained and does not work with TypeScript 7. Run the Node tests with Vitest instead; test files are unchanged thanks to globals. Browser tests still run on karma and will be migrated separately.
keichi
force-pushed
the
migrate-node-tests-to-vitest
branch
from
October 15, 2026 14:03
99e3d86 to
3bacd6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #303 (Node 22+). Base is
bump-node-version; it will retarget tomasteronce #303 is merged.Summary
vitest run) instead of mocha + ts-node. Test files are unchanged (globals: true).ts-node, which is unmaintained and incompatible with TypeScript 7.Browser tests still run on karma (
mochaandkarma-*stay for now). Moving them to Vitest browser mode will be a follow-up PR, after which karma and mocha can be removed.Testing
npm test(Vitest, Node 26 and Node 22): 166 passednpm run test:browser(karma, ChromeHeadless): 166 SUCCESSnpm run buildpasses