Repository navigation
refactor(taskfile): adopt lib v2.6.0 - #9
Merged
Merged
Conversation
- The proton engine names its image: drop IMAGE from the toolbox include (C2). - The toolbox defines no report-engine: drop it from the excludes (C6). - check.yml is the caller of lib's check workflow, with offline: true (C7). - The vars input of sync.yml reaches every task, and LIST_FLOOR and OWNERS there change prune: say so (C26). - github runs daily, and DESC takes the owners from OWNERS (C27). The pins move to v2.6.0, with render.txt, once the tag exists. Until then lib's check workflow at the v2.2.0 pin has no offline input.
… STE - The Taskfile header takes the shared mirror shape (C35): the upstream, the folder, the cadence and the bundle; the includes and the README of lib; the items that are only this mirror's; the secrets by name. The bundle paragraph stays after it. - Every Taskfile comment, the actions: write comment of sync.yml (now on its own lines) and the op.env comments are in ASD-STE100 (C78). No fact goes, and no op:// line changes. The LIST_FLOOR comment adds that the vars input of the sync workflow can change the value (C26).
- The secrets go into the image "with" their names: BY is only a mathematical function word in STE (review m1). - The list comment says "listing", the word the header and the LIST_FLOOR comment use for the same thing (review m2). - The stage comment states first that all persons can read the run log, then where each item goes: the token into the environment of git, not a command line, and the stderr of git into .run/git.err, not the run log (review m3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency review, phase 3, for github: adopt lib v2.6.0 (tagged at 36d75e6) in this mirror's own files.
offline: true. C26 the vars input description is true (LIST_FLOOR and OWNERS there change prune). C27 github is daily; DESC names {{.OWNERS}}.36d75e6).Test plan
task checkagainst v2.6.0 (render.txt accepted afterrm -rf .task/remote)