Skip to content

fix(sonar): clear localization-era smells and vulnerabilities on develop - #1090

Merged
justcoding121 merged 3 commits into
developfrom
fix/sonar-localization-gate-develop
Oct 10, 2026
Merged

justcoding121 merged 3 commits into
developfrom
fix/sonar-localization-gate-develop

Conversation

@justcoding121

Copy link
Copy Markdown
Owner

Summary

  • Remove unsafe CFStringGetCString usage (S6640) via pinned GCHandle.
  • Call /usr/bin/gdbus with an absolute path (S4036).
  • Clear remaining maintainability smells from the localization work (LINQ match, static PressedSessionRow, GeneratedRegex, static chip array; NOSONAR on Avalonia-bound ProxyLocalhostTip).

Test plan

  • Inspector build
  • LanguageCatalogTests + OsUiPreferenceTests
  • Develop .NET workflow + Sonar quality gate OK, code_smells=0, vulnerabilities=0

…lop.

Drop unsafe CFString marshaling, call gdbus by absolute path, and tidy static/LINQ/regex findings so the quality gate can go green.
…2 on tip binding.

Avoid a Mac-only coverage gap on the PR gate; touch settings so ProxyLocalhostTip stays an instance Avalonia binding.
The instance tip getter is required for Avalonia binding; exercise it so new-code coverage clears 80%.
@sonarqubecloud

Copy link
Copy Markdown

@justcoding121
justcoding121 merged commit 1b901c4 into develop Oct 10, 2026
20 checks passed
@justcoding121
justcoding121 deleted the fix/sonar-localization-gate-develop branch October 10, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant