Repository navigation
Conversation
Member
Author
|
I think I should split it in 2. First a JuliaC test that write MOF for a model without ScalarNonlinearFunctions and then a PR dealing with the nonlinear part |
odow
reviewed
Oct 9, 2026
| end | ||
| Base.write(io, JSON.json(object)) | ||
| tree = _json_tree(object)::JSON.Object{String,Any} | ||
| Base.write(io, JSON.json(tree)) |
Member
There was a problem hiding this comment.
I'm open to reviewing small PRs. I'm not very enthused about changes like this. I don't really like that we're making the code much more verbose just to support JuliaC. JuliaC should have some way to deal with type unstable code + a script at compile time.
odow
reviewed
Oct 9, 2026
| return array | ||
| end | ||
| return value | ||
| end |
Member
There was a problem hiding this comment.
This function is ugly... we moved away from dictionaries because they ate up a lot of performance writing very large Sienna instances: #2606
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged as is but rather to take a look at the list of things we need to do to get a MOF writer with JuliaC working.
We should probably discuss on individual changes on separate PRs.